YARN-10480. replace href tags with ng-href#2426
Merged
jojochuang merged 1 commit intoapache:trunkfrom Nov 10, 2020
Merged
Conversation
|
🎊 +1 overall
This message was automatically generated. |
jojochuang
approved these changes
Nov 2, 2020
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Not an expert in this, but looks good to me.
jojochuang
changed the title
asfgit
pushed a commit
that referenced
this pull request
Nov 10, 2020
(cherry picked from commit 61f8c57)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace href tags with ng-href
According to angularjs docs, it is better to use ng-href attributes instead of the default href one.
This prevent angularjs to give broken links to the user, if the evaluation of the link expression takes too long